Jank test: allow specifying remote port#32
Open
jagerman wants to merge 6 commits intosession-foundation:devfrom
Open
Jank test: allow specifying remote port#32jagerman wants to merge 6 commits intosession-foundation:devfrom
jagerman wants to merge 6 commits intosession-foundation:devfrom
Conversation
jagerman
force-pushed
the
jank-test-port
branch
from
88b1790 to
ebf3380
Compare
12345 was hard-coded, but that's a bit annoying: this allows adding `:8888` (or whatever you want) to control the mapped remote port.
jagerman
force-pushed
the
jank-test-port
branch
2 times, most recently
from
2bdfbd5 to
498a5e5
Compare
For 21+, we have to ensure we don't use system oxenc because clang 21 breaks in all sorts of ways with the system fmt 10. It appears that we also need the associated llvm-N package installed for the build to succeed, so this adds that as well.
jagerman
force-pushed
the
jank-test-port
branch
from
498a5e5 to
8345522
Compare
Some components are using WITH_LTO and others are using USE_LTO, and so we can end up with a static library needing LTO linking to one that doesn't, which leads to build failures (particularly with clang).
jagerman
force-pushed
the
jank-test-port
branch
from
e6a8f18 to
6e54d56
Compare
We don't declare libevent a PUBLIC link target, and so we mustn't include its headers in .hpp files. This fixes it with forward declarations/typedef in the .hpp, moving the actual includes to the cpp.
jagerman
force-pushed
the
jank-test-port
branch
from
6e54d56 to
1063daf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12345 was hard-coded, but that's a bit annoying: this allows adding
:8888(or whatever you want) to control the mapped remote port.